chore!: Update default E2EE settings behavior

[yash-rajpal]

Proposed changes (including videos or screenshots)

We introduced a new E2EE settings with 6.x release - E2E_Allow_Unencrypted_Messages. Earlier their default value was kept in a way to not change the default behavior.

We decided to change this default behavior in the major 7.0.0 release and now by default users shouldn't be allowed to send un-encrypted messages in encrypted rooms.

Issue(s)

Steps to test or reproduce

Further comments

E2EE2-69

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: a0d56f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/ui-voip	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33361/
on branch gh-pages at 2024-10-16 12:39 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (390df83) to head (a0d56f4).
Report is 17 commits behind head on release-7.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-7.0.0   #33361      +/-   ##
=================================================
- Coverage          74.80%   74.79%   -0.02%     
=================================================
  Files                468      467       -1     
  Lines              20678    20641      -37     
  Branches            5275     5262      -13     
=================================================
- Hits               15469    15439      -30     
+ Misses              4594     4590       -4     
+ Partials             615      612       -3     

Flag	Coverage Δ
unit	74.79% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[KevLehman]

Did we change the setting creation code in another PR? The this.add(... cause otherwise the code for new workspaces will retain the current behavior as migrations won't run on clean envs

[yash-rajpal]

Did we change the setting creation code in another PR? The this.add(... cause otherwise the code for new workspaces will retain the current behavior as migrations won't run on clean envs

Ohhh, nice catch!! I had done that, but it got lost when solving conflicts.

Done!