-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken jump-to-thread-message functionality using link #33332
Conversation
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 019f2a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33332 +/- ##
===========================================
+ Coverage 58.41% 59.42% +1.00%
===========================================
Files 2744 2608 -136
Lines 66254 64178 -2076
Branches 14990 14425 -565
===========================================
- Hits 38704 38139 -565
+ Misses 24731 23292 -1439
+ Partials 2819 2747 -72
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
…ctor/avatar * 'develop' of github.com:RocketChat/Rocket.Chat: (58 commits) refactor: unified users page header content into a single component (#33498) chore: store contact emails and phones on the same format as user's and visitor's (#33484) fix: broken jump-to-thread-message functionality using link (#33332) feat: Apps-Engine method for reading and counting unread room messages for a user (#32194) feat: adds a new featured room action on the header for non-default category (#33562) chore(deps): bump actions/setup-node from 4.0.3 to 4.0.4 (#33327) fix: consider query strings in Twilio request validation (#33364) ci: add restore cache for `deploy-preview` (#33579) feat: add history endpoint (#33349) ci: cache artifacts to reduce api calls (#33567) feat: new E2EE composer hint (#33283) chore: Add `force` option to `rmSync` call (#33570) chore: remove nameInsensitive sorting on /v1/users.listByStatus (#33401) chore: Use `rmSync` instead of `rmdirSync` (#33551) feat: add contact channels (#33308) chore: split ImportDataConverter into multiple classes and add unit testing (#33394) test: added MockedDeviceContext to voip unit tests (#33553) refactor: adjusted voip endpoints error messages (#33515) fix: Cannot send messages after E2EE keys are refreshed (#33527) fix: Custom sounds not working when storage is set to filesystem (#33424) ...
Proposed changes (including videos or screenshots)
This PR fixes the issue in which the message is not focused into view port by scrolling when we open its url.
Screen.Recording.2024-09-23.at.4.47.12.PM.mov
Issue(s)
Steps to test or reproduce
Further comments
SUP-643