Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove deprecated URL App installation #33210

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Sep 4, 2024

Proposed changes (including videos or screenshots)

Removes a deprecated method of uploading apps using URLs

image

Issue(s)

PASLR-8

Steps to test or reproduce

Further comments

@MartinSchoeler MartinSchoeler added this to the 7.0 milestone Sep 4, 2024
Copy link
Contributor

dionisio-bot bot commented Sep 4, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 3c5c1ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (335ae33) to head (3c5c1ed).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33210   +/-   ##
==============================================
  Coverage          75.32%   75.32%           
==============================================
  Files                383      383           
  Lines              19383    19383           
  Branches            4980     4980           
==============================================
  Hits               14601    14601           
  Misses              4212     4212           
  Partials             570      570           
Flag Coverage Δ
unit 75.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from c6874ac to fff2293 Compare September 11, 2024 22:14
@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from 9ba3bd2 to fcd8105 Compare September 16, 2024 01:13
@MartinSchoeler MartinSchoeler force-pushed the remove-deprecated-setting branch 2 times, most recently from 3e877ce to 30e3d2f Compare September 16, 2024 12:31
Copy link
Contributor

github-actions bot commented Sep 16, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-27 21:23 UTC

@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 19, 2024 16:46
@MartinSchoeler MartinSchoeler requested review from a team as code owners September 19, 2024 16:46
@ggazzo ggazzo requested a review from a team as a code owner September 25, 2024 00:27
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from cb512e1 to 335ae33 Compare September 27, 2024 18:05
tassoevan
tassoevan previously approved these changes Sep 27, 2024
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Sep 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 27, 2024
@ggazzo ggazzo merged commit 50abbe6 into release-7.0.0 Sep 27, 2024
52 checks passed
@ggazzo ggazzo deleted the remove-deprecated-setting branch September 27, 2024 21:22
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants