Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Encrypted file upload throws an error on mobile #33169

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Aug 27, 2024

Proposed changes (including videos or screenshots)

  • Assure encrypted files use the generic application/octet-stream media type before validating it

Issue(s)

Introduced by #33003

Steps to test or reproduce

Further comments

#33003 has caused RC (server side) to throw an error when an encrypted file is uploaded without the generic application/octet-stream media type. Our mobile app uploads encrypted files using their original media type, so the server would always block file uploads in this case

CORE-666

Copy link
Contributor

dionisio-bot bot commented Aug 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: 6a0a111

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.34%. Comparing base (560a432) to head (6a0a111).
Report is 1 commits behind head on release-6.12.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.12.0   #33169      +/-   ##
==================================================
- Coverage           59.39%   59.34%   -0.05%     
==================================================
  Files                2548     2549       +1     
  Lines               63551    63648      +97     
  Branches            14350    14384      +34     
==================================================
+ Hits                37744    37771      +27     
- Misses              23072    23140      +68     
- Partials             2735     2737       +2     
Flag Coverage Δ
unit 75.18% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review August 27, 2024 22:01
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner August 27, 2024 22:01
@matheusbsilva137 matheusbsilva137 changed the title regression: Encrypted file upload throws an error on mobile fix: Encrypted file upload throws an error on mobile Aug 27, 2024
tapiarafael
tapiarafael previously approved these changes Aug 27, 2024
diegolmello
diegolmello previously approved these changes Aug 28, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Aug 28, 2024
@matheusbsilva137 matheusbsilva137 marked this pull request as draft August 28, 2024 15:02
@matheusbsilva137 matheusbsilva137 force-pushed the regression/e2ee-file-upload-mobile branch from 2bf74ef to 6a0a111 Compare August 28, 2024 15:14
@matheusbsilva137 matheusbsilva137 changed the base branch from develop to release-6.12.0 August 28, 2024 15:14
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review August 28, 2024 15:14
@matheusbsilva137 matheusbsilva137 changed the title fix: Encrypted file upload throws an error on mobile regression: Encrypted file upload throws an error on mobile Aug 28, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 28, 2024
@matheusbsilva137 matheusbsilva137 added this to the 6.12 milestone Aug 28, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 28, 2024
@kodiakhq kodiakhq bot merged commit 7180790 into release-6.12.0 Aug 28, 2024
53 checks passed
@kodiakhq kodiakhq bot deleted the regression/e2ee-file-upload-mobile branch August 28, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants