-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Encrypted file upload throws an error on mobile #33169
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 6a0a111 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.12.0 #33169 +/- ##
==================================================
- Coverage 59.39% 59.34% -0.05%
==================================================
Files 2548 2549 +1
Lines 63551 63648 +97
Branches 14350 14384 +34
==================================================
+ Hits 37744 37771 +27
- Misses 23072 23140 +68
- Partials 2735 2737 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
6a0a111
2bf74ef
to
6a0a111
Compare
Proposed changes (including videos or screenshots)
application/octet-stream
media type before validating itIssue(s)
Introduced by #33003
Steps to test or reproduce
Further comments
#33003 has caused RC (server side) to throw an error when an encrypted file is uploaded without the generic
application/octet-stream
media type. Our mobile app uploads encrypted files using their original media type, so the server would always block file uploads in this caseCORE-666