chore!: removes view-history permission

[lucas-a-pelegrino]

Proposed changes (including videos or screenshots)

This PR aims to completely remove the view-history permission, since it has never been used since its creation. It also adds a migration to remove it from the permissions collection, and removes the i18n keys for view-history and view-history-description.

Issue(s)

CORE-605

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 642d0c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (1eae86e) to head (642d0c0).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.0.0   #33042   +/-   ##
==============================================
  Coverage          55.00%   55.00%           
==============================================
  Files               2596     2596           
  Lines              56003    56003           
  Branches           11589    11589           
==============================================
  Hits               30802    30802           
  Misses             22558    22558           
  Partials            2643     2643           

Flag	Coverage Δ
unit	73.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[ggazzo]

ps: there is no need to remove all the i18n keys, if you removes the en lingohub will do the rest for you

also the title should be chore!:

[lucas-a-pelegrino]

ps: there is no need to remove all the i18n keys, if you removes the en lingohub will do the rest for you

also the title should be chore!:

Good to now, I wasn't sure about the i18n being auto removed if I removed only in en.

[KevLehman]

The permissions collection has trash, wonder if we should skip the trash on this delete, like

Permissions.col.deleteOne({ _id: 'view-history' })

[lucas-a-pelegrino]

Hey @KevLehman , can you elaborate? Not sure I understood what you meant.

[KevLehman]

What i mean is that we have something called trash for some DB models. This copies the object before it's deleted into the trash, and then it removes from the original collection.

SO in this case, when removed like this, the permission will be in the trash. Not really sure that's a big concern but would be nice to ask if we can just skip the trash instead for this case.

[lucas-a-pelegrino]

Got it.

@ggazzo , @matheusbsilva137 any thoughts on this?