Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: removes view-history permission #33042

Merged
merged 5 commits into from
Aug 15, 2024
Merged

chore!: removes view-history permission #33042

merged 5 commits into from
Aug 15, 2024

Conversation

lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Aug 13, 2024

Proposed changes (including videos or screenshots)

This PR aims to completely remove the view-history permission, since it has never been used since its creation. It also adds a migration to remove it from the permissions collection, and removes the i18n keys for view-history and view-history-description.

Issue(s)

CORE-605

Steps to test or reproduce

Further comments

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.0 milestone Aug 13, 2024
@lucas-a-pelegrino lucas-a-pelegrino self-assigned this Aug 13, 2024
Copy link
Contributor

dionisio-bot bot commented Aug 13, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 642d0c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lucas-a-pelegrino lucas-a-pelegrino changed the base branch from develop to release-7.0.0 August 13, 2024 20:16
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (1eae86e) to head (642d0c0).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33042   +/-   ##
==============================================
  Coverage          55.00%   55.00%           
==============================================
  Files               2596     2596           
  Lines              56003    56003           
  Branches           11589    11589           
==============================================
  Hits               30802    30802           
  Misses             22558    22558           
  Partials            2643     2643           
Flag Coverage Δ
unit 73.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lucas-a-pelegrino lucas-a-pelegrino changed the base branch from release-7.0.0 to develop August 13, 2024 21:03
@lucas-a-pelegrino lucas-a-pelegrino changed the base branch from develop to release-7.0.0 August 14, 2024 14:56
@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review August 14, 2024 17:15
@lucas-a-pelegrino lucas-a-pelegrino requested a review from a team as a code owner August 14, 2024 17:15
@ggazzo
Copy link
Member

ggazzo commented Aug 14, 2024

ps: there is no need to remove all the i18n keys, if you removes the en lingohub will do the rest for you

also the title should be chore!:

@lucas-a-pelegrino
Copy link
Contributor Author

ps: there is no need to remove all the i18n keys, if you removes the en lingohub will do the rest for you

also the title should be chore!:

Good to now, I wasn't sure about the i18n being auto removed if I removed only in en.

@lucas-a-pelegrino lucas-a-pelegrino changed the title chore: removes view-history permission chore!: removes view-history permission Aug 14, 2024
ggazzo
ggazzo previously approved these changes Aug 14, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 14, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 14, 2024
addMigration({
version: 305,
async up() {
await Permissions.deleteOne({ _id: 'view-history' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permissions collection has trash, wonder if we should skip the trash on this delete, like

Permissions.col.deleteOne({ _id: 'view-history' })

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KevLehman , can you elaborate? Not sure I understood what you meant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What i mean is that we have something called trash for some DB models. This copies the object before it's deleted into the trash, and then it removes from the original collection.

SO in this case, when removed like this, the permission will be in the trash. Not really sure that's a big concern but would be nice to ask if we can just skip the trash instead for this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@ggazzo , @matheusbsilva137 any thoughts on this?

ggazzo added a commit that referenced this pull request Aug 16, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 5, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 5, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 5, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 13, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 13, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 14, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 16, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
MartinSchoeler pushed a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 25, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 25, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 8, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 14, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 15, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants