Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: add indexes for servedBy #33038

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Aug 13, 2024

Proposed changes (including videos or screenshots)

Issue(s)

OPI-41

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 454acd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (8188319) to head (454acd8).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33038   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman
KevLehman previously approved these changes Aug 22, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33038/
on branch gh-pages at 2024-10-28 14:44 UTC

@KevLehman KevLehman changed the title chore: add indexes for servedBy chore!: add indexes for servedBy Oct 17, 2024
@KevLehman
Copy link
Contributor

Since this one drops support for searching by username on the rooms endpoint, it should have a changeset as well 😬

@ggazzo ggazzo modified the milestones: 6.14, 7.0, 7.1.0 Oct 17, 2024
@sampaiodiego sampaiodiego changed the base branch from develop to release-7.0.0 October 28, 2024 14:21
@sampaiodiego sampaiodiego marked this pull request as ready for review October 28, 2024 14:31
@sampaiodiego sampaiodiego requested a review from a team as a code owner October 28, 2024 14:31
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 28, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 28, 2024
@kodiakhq kodiakhq bot merged commit af361a3 into release-7.0.0 Oct 28, 2024
11 of 12 checks passed
@kodiakhq kodiakhq bot deleted the omnichannel-index-improvements branch October 28, 2024 14:35
@sampaiodiego sampaiodiego modified the milestones: 7.1.0, 7.0 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants