Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trace api calls #32779

Merged
merged 37 commits into from
Oct 19, 2024
Merged

feat: Trace api calls #32779

merged 37 commits into from
Oct 19, 2024

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Jul 12, 2024

closes #22335

  • Microservices support
  • Fix BaseRaw on MS
  • EnvVar to enable it
  • Error handling

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/ARCH-1300

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: c0d4135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego marked this pull request as ready for review October 18, 2024 17:03
@sampaiodiego sampaiodiego requested review from a team as code owners October 18, 2024 17:03
sampaiodiego
sampaiodiego previously approved these changes Oct 18, 2024
KevLehman
KevLehman previously approved these changes Oct 18, 2024
@rodrigok
Copy link
Member Author

I can't approve, but LGMT

apps/meteor/app/api/server/api.ts Outdated Show resolved Hide resolved
packages/tracing/src/index.ts Show resolved Hide resolved
packages/tracing/src/traceDatabaseCalls.ts Show resolved Hide resolved
packages/tracing/src/traceDatabaseCalls.ts Show resolved Hide resolved
packages/tracing/src/traceDatabaseCalls.ts Outdated Show resolved Hide resolved
packages/tracing/src/index.ts Show resolved Hide resolved
@sampaiodiego sampaiodiego dismissed stale reviews from KevLehman and themself via 1339608 October 18, 2024 21:48
@rodrigok rodrigok added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
KevLehman
KevLehman previously approved these changes Oct 18, 2024
Copy link
Contributor

kodiakhq bot commented Oct 19, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 19, 2024
@ggazzo ggazzo merged commit 429d000 into develop Oct 19, 2024
22 checks passed
@ggazzo ggazzo deleted the meteor3/tracing branch October 19, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants