Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Removed Mongo 4.4. support and added 7.0 #32162

Merged
merged 13 commits into from
Apr 12, 2024
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 9, 2024

Proposed changes (including videos or screenshots)

basically mongo 4.4 has reached the end of its life, now we are removing support

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Apr 9, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: 877a93b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggazzo ggazzo added this to the 7.0 milestone Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (7ebff42) to head (877a93b).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #32162      +/-   ##
=================================================
+ Coverage          54.67%   55.02%   +0.35%     
=================================================
  Files               2257     2307      +50     
  Lines              50055    50947     +892     
  Branches           10180    10423     +243     
=================================================
+ Hits               27368    28036     +668     
- Misses             20206    20388     +182     
- Partials            2481     2523      +42     
Flag Coverage Δ
e2e 54.15% <ø> (+0.69%) ⬆️
unit 75.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review April 9, 2024 18:55
@ggazzo ggazzo requested a review from a team as a code owner April 9, 2024 18:55
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changeset suggestion removed the 7.0 support addition, maybe we could have a new changeset for that?

Either way we need to update the code that checks what MongoDB version is running:

if (!semver.satisfies(semver.coerce(mongoVersion), '>=4.4.0')) {

.changeset/fair-seahorses-laugh.md Outdated Show resolved Hide resolved
@ggazzo ggazzo requested a review from a team as a code owner April 9, 2024 20:36
apps/meteor/server/startup/serverRunning.js Outdated Show resolved Hide resolved
.changeset/fluffy-knives-count.md Outdated Show resolved Hide resolved
sampaiodiego
sampaiodiego previously approved these changes Apr 11, 2024
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Apr 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 11, 2024
sampaiodiego added a commit that referenced this pull request Oct 9, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
KevLehman pushed a commit that referenced this pull request Oct 9, 2024
sampaiodiego added a commit that referenced this pull request Oct 9, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
KevLehman pushed a commit that referenced this pull request Oct 9, 2024
KevLehman pushed a commit that referenced this pull request Oct 10, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
KevLehman pushed a commit that referenced this pull request Oct 11, 2024
KevLehman pushed a commit that referenced this pull request Oct 11, 2024
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
KevLehman pushed a commit that referenced this pull request Oct 11, 2024
KevLehman pushed a commit that referenced this pull request Oct 11, 2024
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
KevLehman pushed a commit that referenced this pull request Oct 11, 2024
KevLehman pushed a commit that referenced this pull request Oct 11, 2024
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
KevLehman pushed a commit that referenced this pull request Oct 11, 2024
ggazzo added a commit that referenced this pull request Oct 14, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
KevLehman pushed a commit that referenced this pull request Oct 14, 2024
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
ggazzo added a commit that referenced this pull request Oct 15, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
This was referenced Oct 20, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants