chore!: Remove upsert users capability through the `users.update` endpoint #31889

matheusbsilva137 · 2024-03-04T19:41:00Z

Proposed changes (including videos or screenshots)

Remove user upsert behavior from users.update endpoint (by making _id field required);
Do not allow using the joinDefaultChannels param in the users.update endpoint (not used anymore, since upsert is not allowed).

Issue(s)

Steps to test or reproduce

Further comments

CORE-79

changeset-bot · 2024-03-04T19:41:03Z

🦋 Changeset detected

Latest commit: 8b90e74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/rest-typings	Major
@rocket.chat/api-client	Patch
@rocket.chat/core-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/livechat	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/core-typings	Major
@rocket.chat/apps	Patch
@rocket.chat/cron	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-03-05T12:02:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.66%. Comparing base (4610f28) to head (8b90e74).
Report is 4 commits behind head on release-7.0.0.

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.0.0   #31889   +/-   ##
==============================================
  Coverage          75.66%   75.66%           
==============================================
  Files                430      430           
  Lines              19904    19904           
  Branches            5079     5079           
==============================================
  Hits               15060    15060           
  Misses              4273     4273           
  Partials             571      571

Flag	Coverage Δ
unit	`75.66% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

MarcosSpessatto

Can we add one test case for each case just to ensure the behavior?

dionisio-bot · 2024-04-10T13:25:49Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

github-actions · 2024-10-09T22:56:11Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-11 15:17 UTC

…point (#31889) * Do not allow unused joinDefaultChannels param in users.update * Do not allow user creation on users.update endpoint --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>

dionisio-bot bot added the stat: needs QA label Mar 4, 2024

matheusbsilva137 mentioned this pull request Mar 4, 2024

fix: Remove users upsert behavior #31822

Closed

matheusbsilva137 added the squad: core label Mar 4, 2024

matheusbsilva137 added this to the 7.0 milestone Mar 4, 2024

matheusbsilva137 marked this pull request as ready for review March 5, 2024 13:42

matheusbsilva137 requested review from a team as code owners March 5, 2024 13:42

MarcosSpessatto requested changes Mar 11, 2024

View reviewed changes

matheusbsilva137 requested a review from MarcosSpessatto March 14, 2024 15:42

MarcosSpessatto previously approved these changes Mar 14, 2024

View reviewed changes

scuciatto removed this from the 7.0 milestone Mar 14, 2024

matheusbsilva137 modified the milestone: 7.0 Mar 15, 2024

matheusbsilva137 added the do not merge Prevent a PR from being automatically merged label Mar 15, 2024

jessicaschelly added stat: QA tested and removed stat: needs QA labels Mar 15, 2024

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 15, 2024

matheusbsilva137 requested a review from sampaiodiego March 20, 2024 11:50

ggazzo changed the title ~~feat: Remove upsert users capability through the users.update endpoint~~ chore!: Remove upsert users capability through the users.update endpoint Mar 20, 2024

matheusbsilva137 removed the do not merge Prevent a PR from being automatically merged label Mar 28, 2024

dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 28, 2024

matheusbsilva137 added this to the 7.0 milestone Apr 10, 2024

dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Apr 10, 2024

matheusbsilva137 added 4 commits October 9, 2024 19:34

chore!: Improve permissions check on permissions endpoints (#32343)

d9fc711

chore!: Improve permissions check on misc endpoints (#32337)

40cca3c

Fix lint

256bc99

chore!: Improve permissions check on misc endpoints (#32337)

7b2aab2

matheusbsilva137 force-pushed the fix/remove-upsert-users branch from 498206b to 7b2aab2 Compare October 9, 2024 22:38

matheusbsilva137 marked this pull request as draft October 9, 2024 22:39

matheusbsilva137 and others added 2 commits October 9, 2024 19:42

Remove unrelated changes

1e57774

Update four-snakes-deny.md

8b90e74

matheusbsilva137 removed the request for review from a team October 9, 2024 22:43

matheusbsilva137 marked this pull request as ready for review October 9, 2024 22:44

matheusbsilva137 requested a review from MarcosSpessatto October 10, 2024 17:57

MarcosSpessatto approved these changes Oct 11, 2024

View reviewed changes

matheusbsilva137 merged commit 5488e7a into release-7.0.0 Oct 11, 2024
50 checks passed

matheusbsilva137 deleted the fix/remove-upsert-users branch October 11, 2024 15:16

This was referenced Oct 20, 2024

Release 7.0.0 #33677

Closed

Release 7.0.0 #33678

Closed

Release 7.0.0 #33679

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore!: Remove upsert users capability through the `users.update` endpoint #31889

chore!: Remove upsert users capability through the `users.update` endpoint #31889

matheusbsilva137 commented Mar 4, 2024 •

edited

Loading

changeset-bot bot commented Mar 4, 2024 •

edited

Loading

codecov bot commented Mar 5, 2024 •

edited

Loading

MarcosSpessatto left a comment

dionisio-bot bot commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

chore!: Remove upsert users capability through the users.update endpoint #31889

chore!: Remove upsert users capability through the users.update endpoint #31889

Conversation

matheusbsilva137 commented Mar 4, 2024 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

changeset-bot bot commented Mar 4, 2024 • edited Loading

🦋 Changeset detected

codecov bot commented Mar 5, 2024 • edited Loading

Codecov Report

MarcosSpessatto left a comment

Choose a reason for hiding this comment

dionisio-bot bot commented Apr 10, 2024 • edited Loading

github-actions bot commented Oct 9, 2024 • edited Loading

chore!: Remove upsert users capability through the `users.update` endpoint #31889

chore!: Remove upsert users capability through the `users.update` endpoint #31889

matheusbsilva137 commented Mar 4, 2024 •

edited

Loading

changeset-bot bot commented Mar 4, 2024 •

edited

Loading

codecov bot commented Mar 5, 2024 •

edited

Loading

dionisio-bot bot commented Apr 10, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading