Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove unused oauth setting #31102

Merged
merged 13 commits into from
Oct 16, 2024
Merged

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

The settings Accounts_OAuth_Custom_Button_Label_Color , Accounts_OAuth_Custom_Button_Color , *_button_label_color and *_button_color was not being used anymore for oauth buttons

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/SUP-395

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 8f9dd46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hugocostadev hugocostadev added this to the 6.6 milestone Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@e59d783). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #31102   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev modified the milestones: 6.6, 7.0 Dec 4, 2023
@ggazzo ggazzo changed the title fix: remove unused oauth setting chore: remove unused oauth setting Mar 14, 2024
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about a migration to delete? otherwise old instances will show the setting with no translations

@hugocostadev
Copy link
Contributor Author

how about a migration to delete? otherwise old instances will show the setting with no translations

Good idea! I'll work on that! Thanks 🚀

@ggazzo ggazzo changed the title chore: remove unused oauth setting chore!: remove unused oauth setting Apr 9, 2024
@hugocostadev hugocostadev changed the base branch from develop to release-7.0.0 April 11, 2024 13:10
Copy link
Contributor

dionisio-bot bot commented Apr 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@hugocostadev hugocostadev requested a review from a team as a code owner April 11, 2024 16:30
@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from 6033eee to 7ebff42 Compare April 12, 2024 02:02
@ggazzo
Copy link
Member

ggazzo commented Apr 15, 2024

/bark

Copy link
Contributor

dionisio-bot bot commented Apr 15, 2024

AU AU

@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from 472825d to 68fee68 Compare April 24, 2024 14:34
@hugocostadev hugocostadev force-pushed the fix/remove-unused-oauth-setting branch from 00eaf0d to 0b0fd96 Compare October 16, 2024 00:14
ggazzo
ggazzo previously approved these changes Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-31102/
on branch gh-pages at 2024-10-16 12:42 UTC

debdutdeb
debdutdeb previously approved these changes Oct 16, 2024
@hugocostadev hugocostadev dismissed stale reviews from debdutdeb and ggazzo via 5d610ba October 16, 2024 13:19
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@ggazzo ggazzo merged commit 9aff835 into release-7.0.0 Oct 16, 2024
51 checks passed
@ggazzo ggazzo deleted the fix/remove-unused-oauth-setting branch October 16, 2024 17:13
yash-rajpal added a commit that referenced this pull request Oct 16, 2024
ggazzo pushed a commit that referenced this pull request Oct 16, 2024
This reverts commit 9aff835.
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This reverts commit 9aff835.
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This reverts commit 9aff835.
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This reverts commit 9aff835.
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This reverts commit 9aff835.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants