chore!: remove unused oauth setting #31102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f9dd46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #31102 +/- ##
================================================
Coverage ? 74.79%
================================================
Files ? 467
Lines ? 20641
Branches ? 5262
================================================
Hits ? 15439
Misses ? 4590
Partials ? 612
Flags with carried forward coverage won't be shown. Click here to find out more. |
elfajriharsuda
approved these changes
Dec 13, 2023
ggazzo
changed the title
ggazzo
requested changes
Mar 14, 2024
Good idea! I'll work on that! Thanks 🚀 |
ggazzo
changed the title
|
Looks like this PR is ready to merge! 🎉 |
ggazzo
force-pushed
the
release-7.0.0
branch
3 times, most recently
from
6033eee
to
7ebff42
Compare
ggazzo
requested changes
Apr 12, 2024
|
/bark |
|
AU AU |
ggazzo
force-pushed
the
release-7.0.0
branch
3 times, most recently
from
472825d
to
68fee68
Compare
hugocostadev
force-pushed
the
fix/remove-unused-oauth-setting
branch
from
00eaf0d
to
0b0fd96
Compare
ggazzo
previously approved these changes
Oct 16, 2024
|
debdutdeb
previously approved these changes
Oct 16, 2024
ggazzo
approved these changes
Oct 16, 2024
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
yash-rajpal
added a commit
that referenced
this pull request
Oct 16, 2024
This reverts commit 9aff835.
Merged
ggazzo
pushed a commit
that referenced
this pull request
Oct 16, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The settings
Accounts_OAuth_Custom_Button_Label_Color,Accounts_OAuth_Custom_Button_Color,*_button_label_colorand*_button_colorwas not being used anymore for oauth buttonsIssue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/SUP-395