Skip to content

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Jun 7, 2023

Proposed changes (including videos or screenshots)

  • Fix issue with imported messages not being displayed in the room.
  • Fix importer agent being added as a member of every imported room.

Issue(s)

Ported from #29416

Steps to test or reproduce

Further comments

Imported messages were added along with a u._id field, which caused them not to be displayed (messages would have a u._id field and ALSO the uobject with the _id and username fields).

TC-732

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: dc8c2cf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matheusbsilva137 matheusbsilva137 changed the base branch from release-6.2.3 to release-6.2.4 June 7, 2023 02:54
@matheusbsilva137 matheusbsilva137 added this to the 6.2.4 milestone Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #29485 (dc8c2cf) into release-6.2.4 (82273fa) will increase coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.2.4   #29485      +/-   ##
=================================================
+ Coverage          45.64%   46.90%   +1.25%     
=================================================
  Files                722      729       +7     
  Lines              13713    13880     +167     
  Branches            2192     2197       +5     
=================================================
+ Hits                6259     6510     +251     
+ Misses              7153     7054      -99     
- Partials             301      316      +15     
Flag Coverage Δ
e2e 46.87% <ø> (+1.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego merged commit 924c3ef into release-6.2.4 Jun 7, 2023
@sampaiodiego sampaiodiego deleted the fix/importer-messages-not-displayed branch June 7, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants