chore: Change ddpsdk.stream to return subscription #29375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ggazzo
force-pushed
the
chore/sdk-unit-tests
branch
from
39f946c to
177c570
Compare
ggazzo
force-pushed
the
chore/sdk-unit-tests
branch
from
177c570 to
173ef0a
Compare
ggazzo
force-pushed
the
chore/sdk-unit-tests
branch
from
2f5a9b2 to
5185903
Compare
Codecov Report
@@ Coverage Diff @@
## develop #29375 +/- ##
===========================================
+ Coverage 43.27% 46.66% +3.39%
===========================================
Files 664 698 +34
Lines 12629 13071 +442
Branches 2187 2226 +39
===========================================
+ Hits 5465 6100 +635
+ Misses 6867 6652 -215
- Partials 297 319 +22
Flags with carried forward coverage won't be shown. Click here to find out more. |
jeanfbrito
previously approved these changes
May 26, 2023
ggazzo
commented
May 26, 2023
jeanfbrito
previously approved these changes
May 26, 2023
hugocostadev
pushed a commit
that referenced
this pull request
May 30, 2023
gabriellsh
added a commit
that referenced
this pull request
May 31, 2023
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: fix: marketplace filters are changing size (#28738) chore: Update highlighted word color (#29407) i18n: Language update from LingoHub 🤖 on 2023-05-22Z (#29317) chore(ddp-sdk): ts-jest -> swc/jest (#29380) chore: `ToolboxAction` pressed state (#29397) chore: add logs to recurring omnichannel cron jobs (#29392) regression: `t` using always sprintf (#29396) fix: fix wrong %s translations (#29395) regression(push): fix error when selecting what to import (#29289) chore: Change ddpsdk.stream to return subscription (#29375) feat: Implement new Administration kebab reroute algorithm (#29142) chore: New mention styles (#29162)
gabriellsh
added a commit
that referenced
this pull request
Jun 1, 2023
…e/system-messages-update * 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits) fix: Importer crashes when sending the "active status" e-mail notification to users (#29401) docs: new README file (#27955) refactor: replace with new `Select` (#29368) fix: Sidebar's sort by name not being checked properly (#29415) fix: Login Terms custom content (#28999) fix: Broken link fixed inside webhook menu (#29048) fix: Apps settings i18n translation (#29394) fix: OTR session closing after 10 seconds without warning (#29245) fix: Register Username form showing before homepage (#29356) regression(ui-client): Toolbox action button badge in the wrong position (#29412) fix: marketplace filters are changing size (#28738) chore: Update highlighted word color (#29407) i18n: Language update from LingoHub 🤖 on 2023-05-22Z (#29317) chore(ddp-sdk): ts-jest -> swc/jest (#29380) chore: `ToolboxAction` pressed state (#29397) chore: add logs to recurring omnichannel cron jobs (#29392) regression: `t` using always sprintf (#29396) fix: fix wrong %s translations (#29395) regression(push): fix error when selecting what to import (#29289) chore: Change ddpsdk.stream to return subscription (#29375) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments