chore: break down helpers.ts and create new files #28611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28611 +/- ##
===========================================
- Coverage 46.67% 46.60% -0.07%
===========================================
Files 699 699
Lines 13081 13081
Branches 2228 2228
===========================================
- Hits 6106 6097 -9
- Misses 6656 6663 +7
- Partials 319 321 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
rique223
approved these changes
Jun 7, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
This was referenced Jun 9, 2023
gabriellsh
added a commit
that referenced
this pull request
Jun 12, 2023
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits) chore: Pages empty state consistency (#29439) refactor: Convert Omnichannel helper ee to ts (#29274) regression(i18n): Broken translations on client-side startup (#29442) chore: break down helpers.ts and create new files (#28611) test: runInBand unit test (#29484) i18n: system message copy updates (#29372) chore: emoji popup trigger length (#29282) fix: Seat counter including apps (#29489) fix: Invalid message draft (#29474) fix: message deletion fails if has files attached on filesystem storage (#29313) chore: replace meteor.call -> sdk.call (#29318) chore: deprecation api (#29347) fix: Imported messages are not displayed (#29416) chore: convert metrics to ts (#29475) chore: use new Livechat SDK Implementation (#29098) fix: Room history scroll position (#29335) fix: check for $addToSet to be not empty before passing update params (#29378) chore: update `badge-level-0` color (#29460) fix: Saving Business hour throws an alert (#29449) regression: emojiPicker position (#29408) ...
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This pull request helps organize the main functions from
apps/meteor/client/views/marketplace/helpers.ts, by creating individual files in theapps/meteor/client/views/marketplace/helpers/folder.Issue(s)
Steps to test or reproduce
Further comments
MKP-167