refactor: omnichannel on-hold feature #28252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
murtaza98
changed the title
aleksandernsilva
previously requested changes
Mar 14, 2023
...views/room/components/body/composer/ComposerOmnichannel/hooks/useResumeChatOnHoldMutation.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/hooks/checkAgentBeforeTakeInquiry.ts
Outdated
Show resolved
Hide resolved
murtaza98
commented
Mar 14, 2023
...views/room/components/body/composer/ComposerOmnichannel/hooks/useResumeChatOnHoldMutation.ts
Outdated
Show resolved
Hide resolved
murtaza98
commented
Mar 14, 2023
apps/meteor/ee/app/livechat-enterprise/server/hooks/checkAgentBeforeTakeInquiry.ts
Outdated
Show resolved
Hide resolved
murtaza98
dismissed
aleksandernsilva’s stale review
done with the changes, thanks Alek :)
cauefcr
previously approved these changes
Mar 14, 2023
Contributor
cauefcr
left a comment
cauefcr
left a comment
There was a problem hiding this comment.
Simple and good changes, approving.
ggazzo
previously approved these changes
Jun 13, 2023
dionisio-bot
bot
added
stat: ready to merge
kodiakhq
bot
removed
the
stat: ready to merge
Contributor
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
murtaza98
dismissed stale reviews from KevLehman, aleksandernsilva, and ggazzo
via
43a87b5
dionisio-bot
bot
added
stat: ready to merge
Contributor
Author
|
Hello @KevLehman @aleksandernsilva @ggazzo Could you please re-approve this PR? Your previous approvals got lost while solving conflicts |
aleksandernsilva
approved these changes
Jun 14, 2023
KevLehman
approved these changes
Jun 14, 2023
sampaiodiego
approved these changes
Jun 14, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
This was referenced Jun 15, 2023
gabriellsh
added a commit
that referenced
this pull request
Jun 15, 2023
…to fix/slash-stub * 'fix/slash-stub' of github.com:RocketChat/Rocket.Chat: fix: Unable to open Releases inside App info (#29418) ci: improve engagement dashboard selectors (#29541) fix: re-added pagination to department's agents table (#29523) chore: add message body fallback while markup is loading (#29550) fix: spotlight reacts to new rooms (#29547) fix: Emoji being rendered as big (#29493) refactor: omnichannel on-hold feature (#28252) refactor: Livechat Button to TS (#29535)
This was referenced Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Also fixes: Resume on-hold chat not working with max-chat's allowed per agent config (OC-529)
Steps to test or reproduce
Further comments
Note: this only fixes the issue in https://rocketchat.atlassian.net/browse/OC-529 which was caused by Subscription collection not having
onHoldprop. I also some further refactoring of the on-hold feature which can be found here -> #28306