Skip to content

Conversation

@FabioCavaleti
Copy link
Contributor

@FabioCavaleti FabioCavaleti commented Jan 27, 2023

Solving task OC-587

Fix some message errors that were showing in the community edition because some improper endpoints were being accessed.
I fix the error when clicking on close room icon, fix the unauthorized access to units page, and change some deprecated endpointData to useQuery function to calls an endpoint.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@FabioCavaleti FabioCavaleti changed the title FIX: comunity edition users accessing only enterprise edition endpoints in omnichannel section Fix: Comunity edition users accessing only enterprise edition endpoints in omnichannel section Jan 27, 2023
@FabioCavaleti FabioCavaleti changed the title Fix: Comunity edition users accessing only enterprise edition endpoints in omnichannel section [Fix] Comunity edition users accessing only enterprise edition endpoints in omnichannel section Jan 27, 2023
@FabioCavaleti FabioCavaleti changed the title [Fix] Comunity edition users accessing only enterprise edition endpoints in omnichannel section [Fix] Comunity users accessing only ee endpoints in omnichannel section Jan 27, 2023
@FabioCavaleti FabioCavaleti changed the title [Fix] Comunity users accessing only ee endpoints in omnichannel section [FIX] Comunity users accessing only ee endpoints in omnichannel section Jan 27, 2023
@FabioCavaleti FabioCavaleti changed the title [FIX] Comunity users accessing only ee endpoints in omnichannel section [FIX] Comunity users accessing exclusive ee endpoints in omnichannel section Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #27876 (ae0c7d6) into develop (34f0371) will increase coverage by 1.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27876      +/-   ##
===========================================
+ Coverage    42.09%   43.13%   +1.03%     
===========================================
  Files          848      821      -27     
  Lines        17558    17041     -517     
  Branches      2078     2003      -75     
===========================================
- Hits          7391     7350      -41     
+ Misses        9889     9413     -476     
  Partials       278      278              
Flag Coverage Δ
e2e 43.13% <ø> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman
KevLehman previously approved these changes Jan 30, 2023
@FabioCavaleti FabioCavaleti marked this pull request as ready for review January 30, 2023 14:22
@FabioCavaleti FabioCavaleti requested review from a team as code owners January 30, 2023 14:22
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 8, 2023
@kodiakhq kodiakhq bot merged commit 5cc83fe into develop Feb 8, 2023
@kodiakhq kodiakhq bot deleted the fix/click-room-info-icon branch February 8, 2023 13:03
@aleksandernsilva aleksandernsilva added this to the 6.0.0 milestone Feb 9, 2023
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad: omnichannel stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants