Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jan 10, 2023

Proposed changes (including videos or screenshots)

  • TC-347 - SMTP warning for invitations flow
  • Create rest endpoint for sendInvitationEmail
  • Use endpoint in-place of removed Meteor method

Issue(s)

Steps to test or reproduce

Further comments

@yash-rajpal yash-rajpal added this to the 6.0.0 milestone Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #27713 (ce56073) into develop (5f3f001) will increase coverage by 1.08%.
The diff coverage is 63.63%.

❗ Current head ce56073 differs from pull request most recent head 21ce5cd. Consider uploading reports for the commit 21ce5cd to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27713      +/-   ##
===========================================
+ Coverage    42.02%   43.11%   +1.08%     
===========================================
  Files          846      820      -26     
  Lines        17546    17040     -506     
  Branches      2078     2003      -75     
===========================================
- Hits          7374     7347      -27     
+ Misses        9894     9409     -485     
- Partials       278      284       +6     
Flag Coverage Δ
e2e 43.11% <63.63%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review January 12, 2023 19:40
@yash-rajpal yash-rajpal requested review from a team as code owners January 12, 2023 19:40
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text should be centered:
image

hugocostadev
hugocostadev previously approved these changes Jan 17, 2023
hugocostadev
hugocostadev previously approved these changes Jan 20, 2023
@yash-rajpal yash-rajpal changed the title [IMPROVE] SMTP warning for invitations [BREAK] [IMPROVE] SMTP warning for invitations Jan 23, 2023
hugocostadev
hugocostadev previously approved these changes Jan 24, 2023
hugocostadev
hugocostadev previously approved these changes Feb 1, 2023
hugocostadev
hugocostadev previously approved these changes Feb 2, 2023
@tassoevan tassoevan requested a review from gabriellsh February 6, 2023 15:08
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 6, 2023
@rodrigok
Copy link
Member

rodrigok commented Feb 7, 2023

@yash-rajpal please update the description, the method was removed, not deprecated

@kodiakhq kodiakhq bot merged commit c28bb08 into develop Feb 7, 2023
@kodiakhq kodiakhq bot deleted the improve/invites-smtp-flow branch February 7, 2023 20:25
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad: team-collab stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants