Chore: Check for Cloud client secret to check if workspace is registered #27229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionisio-bot
bot
added
stat: ready to merge
|
This pull request introduces 1 alert when merging 4524d82 into f357af4 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 3047c87 into f357af4 - view on LGTM.com new alerts:
|
ggazzo
previously approved these changes
Nov 10, 2022
ggazzo
approved these changes
Nov 11, 2022
bkrith
pushed a commit
to bkrith/Rocket.Chat
that referenced
this pull request
Nov 12, 2022
ggazzo
pushed a commit
that referenced
this pull request
Nov 14, 2022
Merged
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 18, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The main change of this PR is to consider a workspace registered only if it has both
Cloud_Workspace_Client_IdandCloud_Workspace_Client_Secretsettings saved on the server's cache here.The problem was it was checking only for
Cloud_Workspace_Client_Idbut was also using the secret to perform requests afterwards, and due to some race conditions on how settings are saved in cache, it was happening some times theclientIdwas in cache but the secret was not, so now with this additional check it will prevent those cases.The other changes are due to TS conversion.
Issue(s)
ARCH-84
Steps to test or reproduce
Further comments