[FIX] File upload receiving whole file to apply limits #27105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #27105 +/- ##
===========================================
+ Coverage 41.02% 41.82% +0.79%
===========================================
Files 833 808 -25
Lines 18407 17962 -445
Branches 2047 1985 -62
===========================================
- Hits 7552 7512 -40
+ Misses 10568 10163 -405
Partials 287 287
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Nov 1, 2022
d-gubert
approved these changes
Nov 7, 2022
cauefcr
approved these changes
Nov 7, 2022
Contributor
cauefcr
left a comment
cauefcr
left a comment
There was a problem hiding this comment.
It's working great on our omnichannel endpoints, no issues, rejects GB-sized files very fast, approving.
ggazzo
added a commit
that referenced
this pull request
Nov 14, 2022
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Gabriel Casals <83978645+casalsgh@users.noreply.github.com>
Merged
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Gabriel Casals <83978645+casalsgh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
ARCH-56
Steps to test or reproduce
Further comments