[FIX] Uncaught error by listening stream-notify-room without subscription #27020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoevanp
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #27020 +/- ##
===========================================
+ Coverage 40.31% 40.95% +0.64%
===========================================
Files 827 802 -25
Lines 18250 17819 -431
Branches 2031 1972 -59
===========================================
- Hits 7357 7298 -59
+ Misses 10598 10228 -370
+ Partials 295 293 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleksandernsilva
previously approved these changes
Oct 6, 2022
Member
|
@sampaiodiego you're more familiar with this code, can you help us reviewing? 🙏 |
sampaiodiego
previously requested changes
Oct 7, 2022
apps/meteor/server/modules/notifications/notifications.module.ts
Outdated
Show resolved
Hide resolved
Member
|
can you also please create a test for this fix? |
ggazzo
added
stat: ready to merge
tassoevan
dismissed
sampaiodiego’s stale review
The cases where this error could impact the end user (i.e. anonymous viewing a room) have more things to be fixed, therefore a successful test might not be possible without expanding the PR scope a little bit.
tassoevan
approved these changes
Oct 17, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
fix this:
Issue(s)
Steps to test or reproduce
Further comments