Chore: break LDAP manager into smaller pieces to improve unit tests #26994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Oct 4, 2022
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #26994 +/- ##
===========================================
+ Coverage 40.13% 41.03% +0.90%
===========================================
Files 828 802 -26
Lines 18287 17810 -477
Branches 2020 1961 -59
===========================================
- Hits 7339 7309 -30
+ Misses 10654 10207 -447
Partials 294 294
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
previously requested changes
Oct 4, 2022
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
sampaiodiego
approved these changes
Oct 5, 2022
Comment on lines
-1
to
-8
| import { Meteor } from 'meteor/meteor'; | ||
| import { Logger } from '../../../server/lib/logger/Logger'; | ||
|
|
||
| let logger; | ||
|
|
||
| if (Meteor.isServer) { | ||
| const { Logger } = require('../../../server/lib/logger/Logger'); | ||
| logger = new Logger('TemplateVarHandler'); | ||
| } |
Contributor
There was a problem hiding this comment.
Not a problem worth reverting for but this file should've been moved to a "server" folder now that it only works in the server.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments