Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Sep 28, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

OC-254

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #26975 (f066408) into develop (67d5339) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f066408 differs from pull request most recent head 4728dd8. Consider uploading reports for the commit 4728dd8 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26975      +/-   ##
===========================================
+ Coverage    40.11%   40.13%   +0.02%     
===========================================
  Files          829      826       -3     
  Lines        18376    18361      -15     
  Branches      2019     2020       +1     
===========================================
- Hits          7371     7369       -2     
+ Misses       10708    10696      -12     
+ Partials       297      296       -1     
Flag Coverage Δ
e2e 40.13% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review September 29, 2022 13:48
@tiagoevanp tiagoevanp requested a review from a team as a code owner September 29, 2022 13:48
murtaza98
murtaza98 previously approved these changes Sep 29, 2022
KevLehman
KevLehman previously approved these changes Sep 29, 2022
@KevLehman KevLehman dismissed stale reviews from murtaza98 and themself via da91dff September 29, 2022 14:17
@KevLehman KevLehman requested a review from a team as a code owner September 29, 2022 14:18
@KevLehman
Copy link
Member

Hey @tiagoevanp , just added some tests for the endpoint, since we had no tests for it 👀

KevLehman
KevLehman previously approved these changes Sep 29, 2022
@KevLehman KevLehman added this to the 5.2.0 milestone Sep 29, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 29, 2022
@ggazzo ggazzo merged commit 3c96bc7 into develop Oct 4, 2022
@ggazzo ggazzo deleted the regression/empty-contacts branch October 4, 2022 13:23
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants