Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Sep 27, 2022

Proposed changes (including videos or screenshots)

Task: VC-3

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner September 27, 2022 21:45
@dougfabris dougfabris added this to the 5.3.0 milestone Sep 27, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #26966 (0fcbc6a) into develop (a79fadc) will increase coverage by 0.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26966      +/-   ##
===========================================
+ Coverage    40.46%   41.20%   +0.74%     
===========================================
  Files          828      803      -25     
  Lines        18257    17826     -431     
  Branches      2031     1972      -59     
===========================================
- Hits          7388     7346      -42     
+ Misses       10575    10184     -391     
- Partials       294      296       +2     
Flag Coverage Δ
e2e 41.20% <100.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc changed the title Chore: Fix the option to start with camera off on VideoConf [FIX] starting conferences with mic and cam on their default states do sync the state with the provider Oct 5, 2022
@pierre-lehnen-rc pierre-lehnen-rc changed the title [FIX] starting conferences with mic and cam on their default states do sync the state with the provider [FIX] starting conferences with mic and cam on their default states do not sync the state with the provider Oct 6, 2022
gabriellsh
gabriellsh previously approved these changes Oct 19, 2022
@d-gubert d-gubert modified the milestones: 5.3.0, 5.4.0 Oct 19, 2022
@ggazzo ggazzo merged commit 0c6871e into develop Oct 21, 2022
@ggazzo ggazzo deleted the chore/videoconf-preferences branch October 21, 2022 12:29
MartinSchoeler pushed a commit that referenced this pull request Oct 25, 2022
gabriellsh added a commit that referenced this pull request Oct 31, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Unify isLastDocDelayed logic (#27120)
  [FIX] starting conferences with mic and cam on their default states do not sync the state with the provider (#26966)
  [NEW] Matrix federation events coverage expansion (adding support for 3 extra events) (#26859)
  Regression: Quote colors (#27110)
  Regression: Toolbox Divider Color (#27116)
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants