Regression: Fix open room from current chats #26930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26930 +/- ##
===========================================
- Coverage 40.96% 40.88% -0.08%
===========================================
Files 800 793 -7
Lines 17912 17848 -64
Branches 1959 1941 -18
===========================================
- Hits 7337 7297 -40
+ Misses 10278 10255 -23
+ Partials 297 296 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
approved these changes
Sep 23, 2022
KevLehman
requested changes
Sep 23, 2022
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
When you open a chat from current chats, and then you move to another Omnichannel section, this error pops up in console 👀
KevLehman
previously approved these changes
Sep 23, 2022
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
Approving again, as found issue will be dealt as separate regression
MartinSchoeler
approved these changes
Sep 23, 2022
KevLehman
reviewed
Sep 23, 2022
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
Leaving a post-merge approve :( as I just finished testing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments