Skip to content

Conversation

@debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Sep 21, 2022

Proposed changes (including videos or screenshots)

Fixes the error:

errorClass [Error]: [TypeError: subscriptions.find is not a function]
    at app/lib/server/lib/sendNotificationsOnMessage.js:392:11
    at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40 {
  isClientSafe: true,
  error: TypeError: subscriptions.find is not a function
      at app/lib/server/lib/sendNotificationsOnMessage.js:377:41
      at Array.forEach (<anonymous>)
      at app/lib/server/lib/sendNotificationsOnMessage.js:376:11
      at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40,
  reason: undefined,
  details: undefined,
  errorType: 'Meteor.Error'
}

Issue(s)

Fixes #26908

Steps to test or reproduce

Further comments

@debdutdeb debdutdeb added this to the 5.2.0 milestone Sep 21, 2022
Idk what else to write in this commit message sorry.
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #26917 (d7cf19a) into develop (5c26dd9) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d7cf19a differs from pull request most recent head d2fb9df. Consider uploading reports for the commit d2fb9df to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26917      +/-   ##
===========================================
+ Coverage    40.89%   40.91%   +0.02%     
===========================================
  Files          791      791              
  Lines        17809    17809              
  Branches      1928     1928              
===========================================
+ Hits          7283     7287       +4     
+ Misses       10233    10228       -5     
- Partials       293      294       +1     
Flag Coverage Δ
e2e 40.91% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego modified the milestones: 5.2.0, 5.1.3 Sep 21, 2022
@sampaiodiego sampaiodiego changed the title [FIX] subscriptions.find is not a function [FIX] Error when mentioning a non-member of a public channel Sep 21, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 21, 2022
@kodiakhq kodiakhq bot merged commit 6ae770b into develop Sep 21, 2022
@kodiakhq kodiakhq bot deleted the fix/26908 branch September 21, 2022 23:32
@tassoevan tassoevan mentioned this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5.1.2 Crash with: error: TypeError: subscriptions.find is not a function

3 participants