Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 21, 2022

This PR fixes the following:

  • Opening a VoIP room causes a crash (invalid room type)
  • Closing a room causes an error (room not found)
  • Contextual bar not opening automatically when the room is opened (cannot read tabBar from null)

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@RocketChat RocketChat deleted a comment from lgtm-com bot Sep 21, 2022
@RocketChat RocketChat deleted a comment from lgtm-com bot Sep 21, 2022
@ggazzo ggazzo marked this pull request as ready for review September 21, 2022 17:36
@ggazzo ggazzo requested a review from a team as a code owner September 21, 2022 17:36
@ggazzo ggazzo added this to the 5.2.0 milestone Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #26912 (0338bf5) into develop (548d8e6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26912      +/-   ##
===========================================
- Coverage    40.80%   40.79%   -0.01%     
===========================================
  Files          793      793              
  Lines        17851    17848       -3     
  Branches      1940     1941       +1     
===========================================
- Hits          7284     7281       -3     
+ Misses       10271    10268       -3     
- Partials       296      299       +3     
Flag Coverage Δ
e2e 40.79% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo requested a review from a team as a code owner September 22, 2022 02:56
@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2022

This pull request introduces 1 alert when merging 02b2025 into 6ae770b - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-09-22 at 1 49 13 PM

If you try to open a livechat that has been closed via current-chats the channel will appear empty

@MartinSchoeler
Copy link
Member

Screen Shot 2022-09-22 at 1 49 13 PM

If you try to open a livechat that has been closed via current-chats the channel will appear empty

Okay, since the changes are already on develop, this issue is not locked to the scope of this PR, we can work out a fix in another PR

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 22, 2022
@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2022

This pull request introduces 1 alert when merging 0338bf5 into 548d8e6 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@kodiakhq kodiakhq bot merged commit 9625a99 into develop Sep 23, 2022
@kodiakhq kodiakhq bot deleted the regressions/omnichannel branch September 23, 2022 02:43
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants