[FIX] Adjusted livechat fallbacks to take null values into account #26909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26909 +/- ##
===========================================
+ Coverage 39.90% 40.98% +1.08%
===========================================
Files 826 801 -25
Lines 18373 17920 -453
Branches 2019 1960 -59
===========================================
+ Hits 7332 7345 +13
+ Misses 10742 10279 -463
+ Partials 299 296 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
tiagoevanp
previously approved these changes
Sep 21, 2022
ggazzo
previously approved these changes
Sep 21, 2022
tassoevan
previously approved these changes
Sep 21, 2022
Contributor
tassoevan
left a comment
tassoevan
left a comment
There was a problem hiding this comment.
Nullish coalescing (e.g. a ?? b) could be better, but || is fine as we're expecting objects. Just keep it in mind when dealing with falsy primitives.
aleksandernsilva
dismissed stale reviews from tassoevan, ggazzo, and tiagoevanp
via
904e7cc
MartinSchoeler
previously approved these changes
Sep 23, 2022
…livechat-null-room
|
This pull request introduces 1 alert when merging 05dcba1 into ca43434 - view on LGTM.com new alerts:
|
MartinSchoeler
previously approved these changes
Sep 26, 2022
tassoevan
approved these changes
Sep 27, 2022
MartinSchoeler
approved these changes
Sep 27, 2022
tassoevan
added a commit
that referenced
this pull request
Sep 27, 2022
…26909) * [FIX] Adjusted livechat fallbacks to take null values into account * [FIX] Adjusted to clear defaultAgent when department is changed * [FIX] Fixed default guest info not being displayed * [FIX] Adjusted widget default values logic * [FIX] Removing unnecessary check * [FIX] Changed default values logic again to account for changes via api Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OC-209
This pull request fixes:
nullvalues and fallback to the correct default value instead of breaking the widget.defaultAgentnot being cleared from cache when a new department is set