[FIX] Message sequential after message thread preview #26900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipemarins
force-pushed
the
fix/sequential
branch
from
5dde4e3 to
11b0b50
Compare
Codecov Report
@@ Coverage Diff @@
## develop #26900 +/- ##
==========================================
Coverage ? 40.84%
==========================================
Files ? 793
Lines ? 17851
Branches ? 1940
==========================================
Hits ? 7291
Misses ? 10263
Partials ? 297
Flags with carried forward coverage won't be shown. Click here to find out more. |
hugocostadev
suggested changes
Sep 20, 2022
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts
Show resolved
Hide resolved
filipemarins
force-pushed
the
fix/sequential
branch
from
369aafd to
0e24c82
Compare
hugocostadev
previously approved these changes
Sep 20, 2022
ggazzo
previously requested changes
Sep 21, 2022
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.ts
Outdated
Show resolved
Hide resolved
ggazzo
requested changes
Sep 22, 2022
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.ts
Outdated
Show resolved
Hide resolved
filipemarins
force-pushed
the
fix/sequential
branch
from
55a0642 to
08230fe
Compare
filipemarins
force-pushed
the
fix/sequential
branch
from
08230fe to
8161db9
Compare
filipemarins
force-pushed
the
fix/sequential
branch
from
8161db9 to
9426674
Compare
Member
|
I had to change the code because the solution was introducing a different bug (messages from the same thread were never grouping). |
ggazzo
approved these changes
Sep 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Message sequential after message thread preview
Before:
After:
