[FIX] MongoInvalidArgumentError on overwriting existing setting
#26880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26880 +/- ##
===========================================
+ Coverage 40.84% 40.97% +0.13%
===========================================
Files 793 798 +5
Lines 17848 17903 +55
Branches 1941 1959 +18
===========================================
+ Hits 7290 7336 +46
- Misses 10258 10273 +15
+ Partials 300 294 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
previously approved these changes
Sep 22, 2022
Member
|
I've found another case when providing a value via env var would not be applied if the setting props also changed.. I'm working on unit tests to cover both cases |
ggazzo
added
stat: ready to merge
sampaiodiego
approved these changes
Sep 23, 2022
tassoevan
pushed a commit
that referenced
this pull request
Sep 23, 2022
…6880) Co-authored-by: Diego Sampaio <chinello@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments