Skip to content

[IMPROVE] Better descriptions for VoIP Settings #26877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 5 commits into from
Sep 21, 2022
Merged

[IMPROVE] Better descriptions for VoIP Settings #26877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a386bb3
[IMPROVE] Better descriptions for VoIP Settings
MartinSchoeler Sep 14, 2022
d90b0ad
Typo & missing translation
MartinSchoeler Sep 14, 2022
6ca0d37
add placeholders
MartinSchoeler Sep 16, 2022
22e3595
Merge branch 'develop' into improve/voip-settings-descriptions
kodiakhq[bot] Sep 21, 2022
dd0d7e2
Merge branch 'develop' into improve/voip-settings-descriptions
kodiakhq[bot] Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions apps/meteor/app/lib/server/startup/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3216,27 +3216,32 @@ settingsRegistry.addGroup('Troubleshoot', function () {
});

settingsRegistry.addGroup('Call_Center', function () {
// TODO: Check with the backend team if an i18nPlaceholder is possible
this.with({ tab: 'Settings' }, function () {
this.add('VoIP_Enabled', false, {
type: 'boolean',
public: true,
enableQuery: {
_id: 'Livechat_enabled',
value: true,
},
});
this.add('VoIP_JWT_Secret', '', {
type: 'password',
i18nDescription: 'VoIP_JWT_Secret_description',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
},
this.section('General_Settings', function () {
this.add('VoIP_Enabled', false, {
type: 'boolean',
public: true,
i18nDescription: 'VoIP_Enabled_Description',
enableQuery: {
_id: 'Livechat_enabled',
value: true,
},
});
this.add('VoIP_JWT_Secret', '', {
type: 'password',
i18nDescription: 'VoIP_JWT_Secret_description',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
},
});
});
this.section('Server_Configuration', function () {
this.section('Voip_Server_Configuration', function () {
this.add('VoIP_Server_Name', '', {
type: 'string',
public: true,
placeholder: 'WebSocket Server',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
Expand All @@ -3245,6 +3250,7 @@ settingsRegistry.addGroup('Call_Center', function () {
this.add('VoIP_Server_Websocket_Path', '', {
type: 'string',
public: true,
placeholder: 'wss://your.domain.name',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
Expand All @@ -3253,6 +3259,8 @@ settingsRegistry.addGroup('Call_Center', function () {
this.add('VoIP_Retry_Count', -1, {
type: 'int',
public: true,
i18nDescription: 'VoIP_Retry_Count_Description',
placeholder: '1',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
Expand All @@ -3273,6 +3281,7 @@ settingsRegistry.addGroup('Call_Center', function () {
this.add('VoIP_Management_Server_Host', '', {
type: 'string',
public: true,
placeholder: 'https://your.domain.name',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
Expand All @@ -3282,6 +3291,7 @@ settingsRegistry.addGroup('Call_Center', function () {
this.add('VoIP_Management_Server_Port', 0, {
type: 'int',
public: true,
placeholder: '8080',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
Expand All @@ -3291,6 +3301,7 @@ settingsRegistry.addGroup('Call_Center', function () {
this.add('VoIP_Management_Server_Name', '', {
type: 'string',
public: true,
placeholder: 'Server Name',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
Expand All @@ -3300,6 +3311,7 @@ settingsRegistry.addGroup('Call_Center', function () {
this.add('VoIP_Management_Server_Username', '', {
type: 'string',
public: true,
placeholder: 'Username',
enableQuery: {
_id: 'VoIP_Enabled',
value: true,
Expand Down
20 changes: 11 additions & 9 deletions apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,8 +764,8 @@
"cache_cleared": "Cache cleared",
"Call": "Call",
"Calling": "Calling",
"Call_Center": "Call Center",
"Call_Center_Description": "Configure Rocket.Chat call center.",
"Call_Center": "Voice Channel",
"Call_Center_Description": "Configure Rocket.Chat's voice channels",
"Call_ended": "Call ended",
"Calls": "Calls",
"Calls_in_queue": "__calls__ call in queue",
Expand Down Expand Up @@ -2247,6 +2247,7 @@
"Gaming": "Gaming",
"General": "General",
"General_Description": "Configure general workspace settings.",
"General_Settings": "General Settings",
"Generate_new_key": "Generate a new key",
"Generate_New_Link": "Generate New Link",
"Generating_key": "Generating key",
Expand Down Expand Up @@ -3067,7 +3068,7 @@
"Manager_removed": "Manager removed",
"Managers": "Managers",
"manage-chatpal": "Manage Chatpal",
"Management_Server": "Management Server",
"Management_Server": "Asterisk Manager Interface (AMI)",
"Managing_assets": "Managing assets",
"Managing_integrations": "Managing integrations",
"Manual_Selection": "Manual Selection",
Expand Down Expand Up @@ -5180,11 +5181,12 @@
"Visitor_page_URL": "Visitor page URL",
"Visitor_time_on_site": "Visitor time on site",
"Voice_Call": "Voice Call",
"VoIP_Enable_Keep_Alive_For_Unstable_Networks": "Enable Keep-Alive using SIP-OPTIONS for unstable networks",
"VoIP_Enable_Keep_Alive_For_Unstable_Networks_Description": "Enables or Disables Keep-Alive using SIP-OPTIONS based on network quality",
"VoIP_Enabled": "VoIP Enabled",
"VoIP_Enable_Keep_Alive_For_Unstable_Networks": "Enable SIP Options Keep Alive",
"VoIP_Enable_Keep_Alive_For_Unstable_Networks_Description": "Monitor the status of multiple external SIP gateways by sending periodic SIP OPTIONS messages. Used for unstable networks.",
"VoIP_Enabled": "Enable voice channel",
"VoIP_Enabled_Description": "Connect agents to customers through outbound and incoming calls",
"VoIP_Extension": "VoIP Extension",
"Voip_Server_Configuration": "Server Configuration",
"Voip_Server_Configuration": "Asterisk WebSocket Server",
"VoIP_Server_Websocket_Port": "Websocket Port",
"VoIP_Server_Name": "Server Name",
"VoIP_Server_Websocket_Path": "Websocket URL",
Expand All @@ -5204,8 +5206,8 @@
"Voip_call_ended": "Call ended at",
"Voip_call_ended_unexpectedly": "Call ended unexpectedly: __reason__",
"Voip_call_wrapup": "Call wrapup notes added: __comment__",
"VoIP_JWT_Secret": "VoIP JWT Secret",
"VoIP_JWT_Secret_description": "This allows you to set a secret key for sharing extension details from server to client as JWT instead of plain text. If you don't setup this, extension registration details will be sent as plain text",
"VoIP_JWT_Secret": "Secret key (JWT)",
"VoIP_JWT_Secret_description": "Set a secret key for sharing extension details from server to client as JWT instead of plain text. Extension registration details will be sent as plain text if a secret key has not been set.",
"Voip_is_disabled": "VoIP is disabled",
"Voip_is_disabled_description": "To view the list of extensions it is necessary to activate VoIP, do so in the Settings tab.",
"VoIP_Toggle": "Enable/Disable VoIP",
Expand Down
15 changes: 10 additions & 5 deletions apps/meteor/packages/rocketchat-i18n/i18n/pt-BR.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,8 @@
"cache_cleared": "Cache limpo",
"Call": "Ligação",
"Calling": "Chamando",
"Call_Center": "Central de atendimento",
"Call_Center": "Canal de Voz",
"Call_Center_Description": "Configure o canal de voz no Rocket.Chat",
"Calls_in_queue": "__calls__ chamadas na fila",
"Calls_in_queue_plural": "__calls__ Chamadas na Fila",
"Calls_in_queue_empty": "A fila está Vazia",
Expand Down Expand Up @@ -2078,6 +2079,7 @@
"Full_Screen": "Tela cheia",
"Gaming": "Jogos",
"General": "Geral",
"General_Settings": "Configurações Gerais",
"Generate_new_key": "Gerar uma nova chave",
"Generate_New_Link": "Gerar novo link",
"Generating_key": "Gerando chave",
Expand Down Expand Up @@ -2838,7 +2840,7 @@
"Manager_removed": "Gerente removido",
"Managers": "Gerentes",
"manage-chatpal": "Gerenciar Chatpal",
"Management_Server": "Servidor de gerenciamento",
"Management_Server": "Interface de gerenciamento Asterisk (AMI)",
"Managing_assets": "Gerenciando recursos",
"Managing_integrations": "Gerenciando integrações",
"Manual_Selection": "Seleção manual",
Expand Down Expand Up @@ -4733,9 +4735,12 @@
"Visitor_page_URL": "URL da página do visitante",
"Visitor_time_on_site": "Tempo do visitante no site",
"Voice_Call": "Chamada de voz",
"VoIP_Enabled": "VoIP habilitado",
"VoIP_Enabled": "Canal de voz habilitado",
"VoIP_Enabled_Description": "Conecte agentes e clientes através de chamadas de voz",
"VoIP_Enable_Keep_Alive_For_Unstable_Networks": "SIP Options Keep Alive habilitado",
"VoIP_Enable_Keep_Alive_For_Unstable_Networks_Description": "Monitore o status de múltiplos gateways SIP externos enviando mensagens SIP OPTIONS periódicas. Usado para redes instáveis.",
"VoIP_Extension": "Extensão de VoIP",
"Voip_Server_Configuration": "Configuração do servidor",
"Voip_Server_Configuration": "Servidor Websocket Asterisk",
"VoIP_Server_Websocket_Port": "Porta do webSocket",
"VoIP_Server_Name": "Nome do servidor",
"VoIP_Server_Websocket_Path": "URL do webSocket",
Expand All @@ -4753,7 +4758,7 @@
"Voip_call_ended": "Chamada encerrada às",
"Voip_call_ended_unexpectedly": "Chamada encerrada de forma inesperada: __reason__",
"Voip_call_wrapup": "Adição de notas de encerramento da chamada: __comment__",
"VoIP_JWT_Secret": "VoIP JWT Secret",
"VoIP_JWT_Secret": "Chave Secreta JWT",
"VoIP_JWT_Secret_description": "Isso permite que você defina uma chave secreta para compartilhar detalhes da extensão do servidor para o cliente como JWT, em vez de texto simples. Se você não configurar isso, os detalhes do registro da extensão serão enviados como texto simples.",
"Voip_is_disabled": "VoIP está desabilitado",
"Voip_is_disabled_description": "Para ver a lista de extensões é necessário ativar o VoIP, faça isso na aba Configurações.",
Expand Down