[NEW] Move administration links to an exclusive kebab menu #26867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26867 +/- ##
===========================================
+ Coverage 40.76% 41.06% +0.29%
===========================================
Files 801 801
Lines 17919 17918 -1
Branches 1958 1958
===========================================
+ Hits 7305 7358 +53
+ Misses 10319 10260 -59
- Partials 295 300 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This pull request introduces 1 alert when merging 92ea160 into 18b7b4b - view on LGTM.com new alerts:
|
filipemarins
force-pushed
the
feat/kebab
branch
from
92ea160 to
97402e0
Compare
hugocostadev
previously approved these changes
Sep 15, 2022
filipemarins
force-pushed
the
feat/kebab
branch
3 times, most recently
from
ca837db to
8cafdcc
Compare
hugocostadev
previously approved these changes
Sep 20, 2022
filipemarins
force-pushed
the
feat/kebab
branch
from
b851fee to
026766f
Compare
hugocostadev
previously approved these changes
Sep 21, 2022
MartinSchoeler
previously approved these changes
Sep 21, 2022
Member
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
Tested it and functionality wise, all Omnichannel items are working fine.
ggazzo
requested changes
Sep 22, 2022
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
I'm wondering if this section makes sense , since settings belongs to administration and there is only one item
filipemarins
dismissed stale reviews from MartinSchoeler and hugocostadev
via
7a07973
filipemarins
force-pushed
the
feat/kebab
branch
from
7a07973 to
b6ca947
Compare
filipemarins
force-pushed
the
feat/kebab
branch
from
dee849e to
4d7f044
Compare
filipemarins
force-pushed
the
feat/kebab
branch
6 times, most recently
from
e0c4a53 to
9645629
Compare
ggazzo
changed the title
ggazzo
added
stat: needs QA
and removed
stat: QA tested
stat: ready to merge
filipemarins
force-pushed
the
feat/kebab
branch
2 times, most recently
from
606bd12 to
47f8295
Compare
Contributor
Author
I believe it was a design decision after I talked with the product team and the idea was to split these admin section. |
filipemarins
force-pushed
the
feat/kebab
branch
from
47f8295 to
73c36ae
Compare
ggazzo
approved these changes
Sep 23, 2022
Merged
|
This was a semi-optimal idea. pbaity/rocketchat-dark-mode#199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Move administration links to an exclusive kebab menu.
Issue(s)
Steps to test or reproduce
Further comments
Also removed the gold license from the upgrade tab conditional since we no longer commercialize this license.
The App link was split into
MarketplaceandInstalled.The Administration link was split into
Manage WorkspaceandWorkspace settings.New button
upgradewas added.