Chore: Move Omnichannel Room Footer to react #26864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
force-pushed
the
feat/apply-composet
branch
from
fd79850 to
fbe7c6f
Compare
ggazzo
force-pushed
the
feat/apply-composet
branch
from
745e859 to
ae28c58
Compare
Codecov Report
@@ Coverage Diff @@
## develop #26864 +/- ##
===========================================
+ Coverage 40.86% 41.04% +0.18%
===========================================
Files 790 790
Lines 17903 17835 -68
Branches 1927 1929 +2
===========================================
+ Hits 7316 7321 +5
+ Misses 10295 10220 -75
- Partials 292 294 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
force-pushed
the
feat/apply-composet
branch
from
e17ad36 to
cea4f76
Compare
ggazzo
changed the title
MartinSchoeler
requested changes
Sep 15, 2022
Member
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
When I try to open a chat via current-chats page this happens, both when trying to join (using the button) or when I open I chat I'm part of, refreshing fixes this
MartinSchoeler
previously requested changes
Sep 15, 2022
Member
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
When trying to remove a chat from "hold" this error happens
MartinSchoeler
dismissed
their stale review
Both of the issues are happening on develop, out of the context of this PR
MartinSchoeler
previously approved these changes
Sep 15, 2022
MartinSchoeler
approved these changes
Sep 15, 2022
ggazzo
added
stat: QA skipped
stat: ready to merge
pierre-lehnen-rc
approved these changes
Sep 15, 2022
ggazzo
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments