Skip to content

Conversation

@tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #26855 (1a0e025) into develop (e1a4fb4) will increase coverage by 0.28%.
The diff coverage is 73.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26855      +/-   ##
===========================================
+ Coverage    40.72%   41.01%   +0.28%     
===========================================
  Files          793      798       +5     
  Lines        17848    17903      +55     
  Branches      1941     1959      +18     
===========================================
+ Hits          7269     7343      +74     
+ Misses       10279    10258      -21     
- Partials       300      302       +2     
Flag Coverage Δ
e2e 41.01% <73.13%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/room-use-query branch 9 times, most recently from 71b7a7b to a761ccb Compare September 20, 2022 08:35
@tassoevan tassoevan force-pushed the refactor/room-use-query branch from a761ccb to 5187384 Compare September 21, 2022 17:34
@tassoevan tassoevan force-pushed the refactor/room-use-query branch from 5187384 to 8924782 Compare September 21, 2022 17:35
@tassoevan tassoevan changed the title Chore: refactor/room-use-query Chore: Introduce useQuery as data source for the Room component Sep 21, 2022
@tassoevan tassoevan force-pushed the refactor/room-use-query branch from dbb0ed2 to 38be84c Compare September 22, 2022 17:06
@tassoevan tassoevan added this to the 5.2.0 milestone Sep 22, 2022
@tassoevan tassoevan marked this pull request as ready for review September 22, 2022 20:54
@tassoevan tassoevan requested review from a team as code owners September 22, 2022 20:54
@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2022

This pull request introduces 1 alert when merging f30f44a into 0fc1828 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2022

This pull request introduces 1 alert when merging 20b9323 into e1a4fb4 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@ggazzo ggazzo merged commit d8e883b into develop Sep 23, 2022
@ggazzo ggazzo deleted the refactor/room-use-query branch September 23, 2022 16:37
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants