Chore: Rewrite apps WarningModal component to typescript #26845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translated the admin apps WarningModal component from Javascript to Typescript
Codecov Report
@@ Coverage Diff @@
## develop #26845 +/- ##
===========================================
- Coverage 40.58% 40.57% -0.01%
===========================================
Files 791 790 -1
Lines 17901 17898 -3
Branches 1927 1927
===========================================
- Hits 7266 7263 -3
+ Misses 10344 10342 -2
- Partials 291 293 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
changed the title
juliajforesti
approved these changes
Sep 12, 2022
ggazzo
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Translated the admin apps WarningModal component from Javascript to Typescript
Issue(s)
Steps to test or reproduce
Further comments