Chore: Omnichannel endpoints to ts #26829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/Rocket.Chat into chore/make-endpoints-async-omn
KevLehman
changed the base branch from
develop
to
chore/make-endpoints-async-omn
…Chat into chore/endpoints-to-ts
|
This pull request introduces 1 alert when merging 951da92 into e83f80e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 162a2ed into 0d54185 - view on LGTM.com new alerts:
|
murtaza98
reviewed
Sep 15, 2022
murtaza98
reviewed
Sep 15, 2022
murtaza98
reviewed
Sep 15, 2022
murtaza98
reviewed
Sep 15, 2022
Contributor
murtaza98
left a comment
murtaza98
left a comment
There was a problem hiding this comment.
@KevLehman Left a few comments here. Please check
sampaiodiego
approved these changes
Sep 21, 2022
Member
Author
|
They will go when we start migrating that big Livechat service into an actual service 🙈 no ETA for that yet, but happening soon |
MartinSchoeler
approved these changes
Sep 21, 2022
Member
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
Checked the places where the Client Files were modified and it seems to be working OK, the FE code is OK as well (mostly typing or fallback changes)
cauefcr
approved these changes
Sep 21, 2022
ggazzo
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
JIRA be happy: OC-66