Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Sep 6, 2022

Proposed changes (including videos or screenshots)

Our mobile app uses a different method to log in that was removed at #24879 .

You can also make it available only on mobile:
image

Removes the "Sign in with Apple" text from the log in button. This was something we thought were required by Apple, but it is actually allowed to have just the logo as all others OAuth we have. Source: https://developer.apple.com/design/human-interface-guidelines/technologies/sign-in-with-apple/buttons/#creating-a-custom-sign-in-with-apple-button

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team September 6, 2022 22:34
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #26827 (0871aec) into develop (f8b62b1) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26827      +/-   ##
===========================================
+ Coverage    40.57%   40.59%   +0.01%     
===========================================
  Files          799      799              
  Lines        18289    18289              
  Branches      1959     1959              
===========================================
+ Hits          7421     7424       +3     
+ Misses       10571    10570       -1     
+ Partials       297      295       -2     
Flag Coverage Δ
e2e 40.59% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 7, 2022
@kodiakhq kodiakhq bot merged commit d30e08e into develop Sep 8, 2022
@kodiakhq kodiakhq bot deleted the fix-apple-mobile-login branch September 8, 2022 14:39
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants