Skip to content

Conversation

@LucianoPierdona
Copy link
Contributor

@LucianoPierdona LucianoPierdona commented Sep 6, 2022

Proposed changes (including videos or screenshots)

This PR includes a new call for the method syncAvatars when ldap.syncNow is called

Issue(s)

Fixes #24555

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #26824 (db53382) into develop (f8294ef) will increase coverage by 0.17%.
The diff coverage is n/a.

❗ Current head db53382 differs from pull request most recent head 7147277. Consider uploading reports for the commit 7147277 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26824      +/-   ##
===========================================
+ Coverage    40.43%   40.60%   +0.17%     
===========================================
  Files          791      799       +8     
  Lines        17901    18289     +388     
  Branches      1927     1959      +32     
===========================================
+ Hits          7238     7427     +189     
- Misses       10370    10567     +197     
- Partials       293      295       +2     
Flag Coverage Δ
e2e 40.60% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 12, 2022
@kodiakhq kodiakhq bot merged commit 5474569 into develop Sep 12, 2022
@kodiakhq kodiakhq bot deleted the improve/sync-avatars branch September 12, 2022 18:57
@alvaropmello alvaropmello added this to the 5.2.0 milestone Sep 21, 2022
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad: team-collab stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][LDAP][Enterprise] Avatars not updated

6 participants