Skip to content

[FIX] Livechat trigger messages covering all the website #26776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 4 commits into from
Sep 5, 2022
Merged

[FIX] Livechat trigger messages covering all the website #26776

kodiakhq merged 4 commits into from
Sep 5, 2022

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Sep 1, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tiagoevanp tiagoevanp added this to the 5.1.1 milestone Sep 1, 2022
MartinSchoeler
MartinSchoeler requested changes Sep 1, 2022
View reviewed changes
MartinSchoeler
MartinSchoeler requested changes Sep 1, 2022
View reviewed changes
@tiagoevanp tiagoevanp force-pushed the fix/livechat-trigger-mobile branch from 009364f to 4ef286c Compare September 1, 2022 14:40
@tiagoevanp tiagoevanp marked this pull request as ready for review September 1, 2022 14:43
@tiagoevanp tiagoevanp requested review from a team as code owners September 1, 2022 14:43
@tiagoevanp tiagoevanp force-pushed the fix/livechat-trigger-mobile branch from 4ef286c to 5ba742c Compare September 1, 2022 14:47
@tiagoevanp tiagoevanp force-pushed the fix/livechat-trigger-mobile branch from 5ba742c to b36bd23 Compare September 1, 2022 14:49
@codecov
Copy link

codecov bot commented Sep 1, 2022 •
edited
Loading

Codecov Report

Merging #26776 (154d0bb) into develop (78dbb69) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26776      +/-   ##
===========================================
+ Coverage    40.52%   40.54%   +0.02%     
===========================================
  Files          799      799              
  Lines        18296    18296              
  Branches      1954     1954              
===========================================
+ Hits          7415     7419       +4     
+ Misses       10588    10580       -8     
- Partials       293      297       +4
Flag Coverage Δ
e2e 40.54% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2022
@kodiakhq kodiakhq bot merged commit 9513629 into develop Sep 5, 2022
@kodiakhq kodiakhq bot deleted the fix/livechat-trigger-mobile branch September 5, 2022 21:15
tassoevan pushed a commit that referenced this pull request Sep 6, 2022
@tiagoevanp @tassoevan
[FIX] Livechat trigger messages covering all the website (#26776)
5e1f6ab
@tassoevan tassoevan mentioned this pull request Sep 6, 2022
Merged
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees

No one assigned

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

5.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@tiagoevanp @aleksandernsilva @MartinSchoeler @ggazzo @Harmeet221