Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 31, 2022

Proposed changes (including videos or screenshots)

Task: VC-5

Screen Shot 2022-08-30 at 23 15 18

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner August 31, 2022 02:11
@dougfabris dougfabris force-pushed the improve/header-component branch from 47faa06 to 67578ea Compare August 31, 2022 02:17
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #26757 (fa4b9dd) into develop (effda0e) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head fa4b9dd differs from pull request most recent head cf4a1db. Consider uploading reports for the commit cf4a1db to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26757      +/-   ##
===========================================
- Coverage    40.59%   40.46%   -0.14%     
===========================================
  Files          790      799       +9     
  Lines        17903    18309     +406     
  Branches      1927     1957      +30     
===========================================
+ Hits          7268     7408     +140     
- Misses       10343    10602     +259     
- Partials       292      299       +7     
Flag Coverage Δ
e2e 40.46% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@alvaropmello alvaropmello added this to the 5.2.0 milestone Sep 13, 2022
@ggazzo ggazzo self-assigned this Sep 14, 2022
@ggazzo ggazzo requested review from a team as code owners September 15, 2022 15:33
@ggazzo ggazzo force-pushed the improve/header-component branch from e432116 to 6e0eee0 Compare September 15, 2022 15:35
@ggazzo ggazzo changed the title [IMPROVE] Allow featured actions on Header ToolBox Chore: Move Header to ui-client Sep 15, 2022
ggazzo
ggazzo previously approved these changes Sep 15, 2022
ggazzo
ggazzo previously approved these changes Sep 15, 2022
@ggazzo ggazzo removed request for a team September 15, 2022 15:49
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 15, 2022
@kodiakhq kodiakhq bot merged commit c604e4b into develop Sep 15, 2022
@kodiakhq kodiakhq bot deleted the improve/header-component branch September 15, 2022 16:57
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants