-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Chore: Cleanup endpoint handlers #26749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request introduces 2 alerts when merging 050186a into 473455a - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #26749 +/- ##
===========================================
+ Coverage 40.41% 40.54% +0.13%
===========================================
Files 799 799
Lines 18289 18289
Branches 1959 1959
===========================================
+ Hits 7392 7416 +24
+ Misses 10601 10573 -28
- Partials 296 300 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
…t/Rocket.Chat into chore/make-endpoints-async-omn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quarter way One file through I'm moving on for today 🙈
apps/meteor/ee/app/livechat-enterprise/server/api/departments.js
Outdated
Show resolved
Hide resolved
- removing unused variables - permission checks which are no longer required
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments