Chore: Remove & Test cannedResponse meteor templates #26706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 26, 2022
aleksandernsilva
requested changes
Aug 26, 2022
Comment on lines
+58
to
+61
| await test.step('Expect to be able to open canned responses sidebar and creation', async () => { | ||
| await agent.poHomeChannel.content.btnCannedResponses.click(); | ||
| await agent.poHomeChannel.content.btnNewCannedResponse.click(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Shouldn't we have at least one assertion here to confirm if the screen is in the expected state?
Member
Author
There was a problem hiding this comment.
The idea is to create the framework of the test so the coverage can detect the changes
Codecov Report
@@ Coverage Diff @@
## develop #26706 +/- ##
===========================================
+ Coverage 40.39% 40.67% +0.28%
===========================================
Files 802 800 -2
Lines 18446 18324 -122
Branches 1956 1956
===========================================
+ Hits 7451 7454 +3
+ Misses 10702 10578 -124
+ Partials 293 292 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.