[IMPROVE] Results of user auto complete #26687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26687 +/- ##
===========================================
+ Coverage 40.19% 41.03% +0.83%
===========================================
Files 826 801 -25
Lines 18361 17908 -453
Branches 2020 1961 -59
===========================================
- Hits 7380 7348 -32
+ Misses 10684 10264 -420
+ Partials 297 296 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
reviewed
Sep 23, 2022
ggazzo
requested changes
Sep 23, 2022
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
please check my comments above, feel free to dismiss if makes no sense
sampaiodiego
requested changes
Sep 29, 2022
…ket.Chat into improve/user-autocomplete
sampaiodiego
previously approved these changes
Sep 29, 2022
…ket.Chat into improve/user-autocomplete
sampaiodiego
approved these changes
Sep 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When searching for users on autocomplete, list first the users that the requester has DMs with;
If the requester doesn't have permission to view outside their assigned rooms, search for users that have rooms in common instead of returning an empty list.
Issue(s)
Steps to test or reproduce
Further comments