Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Aug 18, 2022

Proposed changes (including videos or screenshots)

This issue was caused by #25556 and since then Docker image for micro services are not being published with the correct tag. That means all 5.0.x releases don't have a published Docker image with the version tag.

The main was using $IMAGE_TAG instead of $DOCKER_TAG to publish the correct tag to DockerHub. I've changed the workflow do make the services publish to look similar to official one. Ideally they could be in a new action file.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner August 18, 2022 14:17
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #26608 (61f6953) into develop (fe26bce) will increase coverage by 0.17%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26608      +/-   ##
===========================================
+ Coverage    38.54%   38.71%   +0.17%     
===========================================
  Files          758      759       +1     
  Lines        18827    18834       +7     
  Branches      1453     1453              
===========================================
+ Hits          7256     7292      +36     
+ Misses       11355    11323      -32     
- Partials       216      219       +3     
Flag Coverage Δ
e2e 38.71% <91.66%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego merged commit 563cc08 into develop Aug 18, 2022
@sampaiodiego sampaiodiego deleted the fix-services-dockerhub-images branch August 18, 2022 16:47
@sampaiodiego sampaiodiego added this to the 5.0.4 milestone Aug 18, 2022
@murtaza98 murtaza98 mentioned this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants