Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Aug 16, 2022

Proposed changes (including videos or screenshots)

A new check added to getPasswordPolicy method was causing some "undefined" errors when users were trying to reset their password.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested review from a team as code owners August 16, 2022 20:49
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #26597 (0ae62cb) into develop (5bca39e) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 0ae62cb differs from pull request most recent head 96eaaa7. Consider uploading reports for the commit 96eaaa7 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26597      +/-   ##
===========================================
+ Coverage    38.53%   38.66%   +0.12%     
===========================================
  Files          758      758              
  Lines        18823    18823              
  Branches      1453     1453              
===========================================
+ Hits          7254     7277      +23     
+ Misses       11351    11328      -23     
  Partials       218      218              
Flag Coverage Δ
e2e 38.66% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit fe26bce into develop Aug 17, 2022
@kodiakhq kodiakhq bot deleted the fix-reset-password-errors branch August 17, 2022 15:10
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants