Regression: Team name validation failing always. #26574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPierdona
previously approved these changes
Aug 15, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26574 +/- ##
===========================================
+ Coverage 38.55% 38.64% +0.09%
===========================================
Files 758 758
Lines 18816 18816
Branches 1459 1459
===========================================
+ Hits 7254 7271 +17
+ Misses 11344 11325 -19
- Partials 218 220 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
requested changes
Aug 16, 2022
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
could you create a test for this case? just to be sure we never gonna repeat this mistake again :x
ggazzo
changed the title
ggazzo
approved these changes
Aug 16, 2022
Member
|
I heard @souzaramon is covering this test case so we are good to go |
ggazzo
added
stat: ready to merge
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments