Chore: Refactor RoomMembers to Typescript #26559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougfabris
changed the title
gabriellsh
previously requested changes
Aug 17, 2022
apps/meteor/client/views/room/contextualBar/RoomMembers/AddUsers/AddUsers.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #26559 +/- ##
=========================================
Coverage 38.67% 38.68%
=========================================
Files 758 751 -7
Lines 18783 18670 -113
Branches 1453 1453
=========================================
- Hits 7265 7223 -42
+ Misses 11302 11227 -75
- Partials 216 220 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Aug 19, 2022
ggazzo
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments