[FIX] Save edited tags for omnichannel departments #26481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26481 +/- ##
===========================================
+ Coverage 38.54% 38.70% +0.16%
===========================================
Files 758 758
Lines 18827 18829 +2
Branches 1453 1453
===========================================
+ Hits 7256 7288 +32
+ Misses 11355 11325 -30
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more. |
…edit-department-tag
…t.Chat into fix/edit-department-tag
aleksandernsilva
requested changes
Aug 8, 2022
apps/meteor/client/views/omnichannel/departments/EditDepartment.js
Outdated
Show resolved
Hide resolved
ggazzo
requested changes
Aug 10, 2022
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
I think comparing the old x new value would be the best solution
btw dont forget e2e tests!
KevLehman
previously approved these changes
Aug 15, 2022
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
Function-wise seems to be working 👀
aleksandernsilva
previously approved these changes
Aug 16, 2022
ggazzo
reviewed
Aug 17, 2022
apps/meteor/client/views/omnichannel/departments/EditDepartment.js
Outdated
Show resolved
Hide resolved
…t.js Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
aleksandernsilva
previously approved these changes
Aug 17, 2022
ggazzo
approved these changes
Aug 17, 2022
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Co-authored-by: Aleksander Nicacio da Silva <6494543+aleksandernsilva@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
A simple workaround for the main problem, when editing a department must be possible to save addition or remotion of tags.
Issue(s)
Steps to test or reproduce
Further comments