Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Aug 3, 2022

Proposed changes (including videos or screenshots)

Publish required notification subscription fields on change, so that changes can be seen on save.

Issue(s)

Closes #21503

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #26461 (220ea40) into develop (5bca39e) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 220ea40 differs from pull request most recent head ccad581. Consider uploading reports for the commit ccad581 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26461      +/-   ##
===========================================
+ Coverage    38.53%   38.63%   +0.10%     
===========================================
  Files          758      758              
  Lines        18823    18820       -3     
  Branches      1453     1452       -1     
===========================================
+ Hits          7254     7272      +18     
+ Misses       11351    11331      -20     
+ Partials       218      217       -1     
Flag Coverage Δ
e2e 38.63% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankar84
Copy link

ankar84 commented Aug 4, 2022

Wait that fix to merge!
Thank you so much, @yash-rajpal

ggazzo
ggazzo previously approved these changes Aug 5, 2022
ggazzo
ggazzo previously approved these changes Aug 8, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 8, 2022
@yash-rajpal yash-rajpal marked this pull request as draft August 8, 2022 16:46
@yash-rajpal yash-rajpal marked this pull request as ready for review August 9, 2022 19:01
ggazzo
ggazzo previously approved these changes Aug 16, 2022
@kodiakhq kodiakhq bot merged commit ddfcf87 into develop Aug 17, 2022
@kodiakhq kodiakhq bot deleted the fix/publish-notification-subscription-fields branch August 17, 2022 16:39
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Per channel notification preferences not all saved

4 participants