Skip to content

Chore: fix tests with beforeEach #26335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 10 commits into from
Jul 27, 2022
Merged

Chore: fix tests with beforeEach #26335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
840fd64
refactor: fix test with beforeEach
weslley543 Jul 21, 2022
5f066e6
refactor: removing persistence of page
weslley543 Jul 21, 2022
e3fd355
refactor: remove befereAll
weslley543 Jul 25, 2022
5b7f5fd
Merge branch 'develop' into refactor/adjust-in-hooks
weslley543 Jul 25, 2022
a2ef7b8
fix: administration test
weslley543 Jul 25, 2022
3cd1f81
refactor: test 13 is working
weslley543 Jul 25, 2022
254c6a9
refactor: adjust tests broken
weslley543 Jul 26, 2022
65e2b79
refactor: set all test to workin with beforeEach
weslley543 Jul 26, 2022
afa905e
refactor: set all test to workin with beforeEach
weslley543 Jul 26, 2022
49b0982
refactor: rewrite messaging tests
Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions apps/meteor/tests/e2e/01-forgot-password.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
import { Page, test, expect } from '@playwright/test';
import { test, expect } from '@playwright/test';

import { Auth } from './page-objects';

test.describe('Forgot Password', () => {
let page: Page;
let pageAuth: Auth;

test.beforeAll(async ({ browser }) => {
page = await browser.newPage();
test.beforeEach(async ({ page }) => {
pageAuth = new Auth(page);
});

test.beforeAll(async () => {
test.beforeEach(async ({ page }) => {
await page.goto('/');
await pageAuth.btnForgotPassword.click();
});
Expand Down
8 changes: 3 additions & 5 deletions apps/meteor/tests/e2e/02-register.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
import { Page, test, expect } from '@playwright/test';
import { test, expect } from '@playwright/test';
import { faker } from '@faker-js/faker';

import { Auth } from './page-objects';

test.describe('Register', () => {
let page: Page;
let pageAuth: Auth;

test.beforeAll(async ({ browser }) => {
page = await browser.newPage();
test.beforeEach(async ({ page }) => {
pageAuth = new Auth(page);
});

test.beforeEach(async () => {
test.beforeEach(async ({ page }) => {
await page.goto('/');
await pageAuth.btnRegister.click();
});
Expand Down
9 changes: 3 additions & 6 deletions apps/meteor/tests/e2e/03-login.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
import { Page, test, expect } from '@playwright/test';
import { test, expect } from '@playwright/test';
import { faker } from '@faker-js/faker';

import { Auth } from './page-objects';

test.describe('Login', () => {
let page: Page;
let pageAuth: Auth;

test.beforeAll(async ({ browser }) => {
page = await browser.newPage();
test.beforeEach(async ({ page }) => {
pageAuth = new Auth(page);
await page.goto('/');
});

test('expect to show a toast if the provided password is incorrect', async () => {
await page.goto('/');

await pageAuth.inputEmailOrUsername.type(faker.internet.email());
await pageAuth.inputPassword.type('any_password');
await pageAuth.btnSubmit.click();
Expand Down
12 changes: 5 additions & 7 deletions apps/meteor/tests/e2e/05-channel-creation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,22 @@
import { Page, test, expect } from '@playwright/test';
import { test, expect } from '@playwright/test';
import { faker } from '@faker-js/faker';

import { HomeChannel, Auth } from './page-objects';

test.describe('Channel Creation', () => {
let page: Page;
let pageAuth: Auth;
let pageHomeChannel: HomeChannel;

test.beforeAll(async ({ browser }) => {
page = await browser.newPage();
test.beforeEach(async ({ page }) => {
pageAuth = new Auth(page);
pageHomeChannel = new HomeChannel(page);
});

test.beforeAll(async () => {
test.beforeEach(async () => {
await pageAuth.doLogin();
});

test('expect create public channel', async () => {
test('expect create public channel', async ({ page }) => {
const name = faker.animal.type() + Date.now();

await pageHomeChannel.sidenav.btnCreate.click();
Expand All @@ -30,7 +28,7 @@ test.describe('Channel Creation', () => {
await expect(page).toHaveURL(`/channel/${name}`);
});

test('expect create private channel', async () => {
test('expect create private channel', async ({ page }) => {
const name = faker.animal.type() + Date.now();

await pageHomeChannel.sidenav.btnCreate.click();
Expand Down
Loading