Skip to content

Regression: Special characters on phone number #26241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 18 commits into from
Jul 20, 2022
Merged

Regression: Special characters on phone number #26241

ggazzo merged 18 commits into from
Jul 20, 2022

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jul 12, 2022

Proposed changes (including videos or screenshots)

PR Includes:

  • Keep focus on phone input of dial pad
  • Handle submit with "Enter" key
  • Remove mask and mandatory "+" char
  • Long press for "0"/"+" button

Issue(s)

Steps to test or reproduce

Further comments

aleksandernsilva
aleksandernsilva requested changes Jul 13, 2022
View reviewed changes
@tiagoevanp tiagoevanp added this to the 5.0.0 milestone Jul 13, 2022
aleksandernsilva
aleksandernsilva requested changes Jul 15, 2022
View reviewed changes
Filipe Marins and others added 2 commits July 18, 2022 14:38
@tiagoevanp tiagoevanp force-pushed the regression/dial-pad branch from 285c546 to 2044463 Compare July 18, 2022 17:39
@RocketChat RocketChat deleted a comment from CLAassistant Jul 18, 2022
@tiagoevanp tiagoevanp requested a review from a team as a code owner July 19, 2022 14:49
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 20, 2022
@ggazzo ggazzo merged commit 3d989b6 into develop Jul 20, 2022
@ggazzo ggazzo deleted the regression/dial-pad branch July 20, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

@KevLehman KevLehman KevLehman approved these changes

Assignees

No one assigned

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@tiagoevanp @aleksandernsilva @KevLehman @ggazzo @casalsgh @Harmeet221