-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[FIX] Unable to remove a user who joined a public team with a mention #26218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix/remove-user-from-mention
matheusbsilva137
suggested changes
Jul 27, 2022
matheusbsilva137
suggested changes
Jul 28, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26218 +/- ##
===========================================
+ Coverage 38.60% 38.65% +0.05%
===========================================
Files 758 758
Lines 18820 18816 -4
Branches 1452 1459 +7
===========================================
+ Hits 7266 7274 +8
+ Misses 11334 11322 -12
Partials 220 220
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ketChat/Rocket.Chat into fix/remove-user-from-mention
…nto fix/remove-user-from-mention
matheusbsilva137
suggested changes
Aug 15, 2022
…ketChat/Rocket.Chat into fix/remove-user-from-mention
matheusbsilva137
approved these changes
Aug 16, 2022
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
…#26218) Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes a bug where a user that joins a team by mention don't get added to the team.
Issue(s)
Fix #25817
Steps to test or reproduce
Further comments